i#6662 public traces: add instr_t operation_size API #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds instr_get_operation_size() and instr_set_operation_size() public APIs for DR_ISA_REGDEPS instructions, which are currently the only instructions for which operation_size is defined. We set operation_size of DR_ISA_REGDEPS instructions with no operands to OPSZ_0 in the convertion to REGDEPS process, so decoded and converted instructions look the same. Previously a converted instruction might have had an operation_size different than OPSZ_0 even with no register operands, that would then be corrected during encoding and subsequent decoding. This is mostly for convenience when testing. We update a test to also invoke the instr_length() API on DR_ISA_REGDEPS instructions. Issue #6662
It's not set, decode sets it.
derekbruening
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instr_get_operation_size() and instr_set_operation_size() public
APIs for DR_ISA_REGDEPS instructions, which are currently the only
instructions for which operation_size is defined.
We set operation_size of DR_ISA_REGDEPS instructions with no
operands to OPSZ_0 in the convertion to REGDEPS process,
so decoded and converted instructions look the same.
Previously a converted instruction might have had an operation_size
different than OPSZ_0 even with no register operands, that would
then be corrected during encoding and subsequent decoding.
This is mostly for convenience when testing.
We update a test to also invoke the instr_length() API on
DR_ISA_REGDEPS instructions.
Issue #6662