i#3699 ARM: Keep stack aligned in insert_{push,pop}_all_registers. #7149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd1589c modified dstack_offs in insert_push_all_registers without generating an instruction that modifies SP. So add a SUB SP, SP, #4 there, and a corresponding ADD SP, SP, #4 in insert_pop_all_registers. This made the test client.cleancallparams pass. Issue: #3699 Change-Id: I25d2a22e7feb7bc1227aeec74847c80754eae254
Change-Id: Ieeea1c87e51b07021b7e1dd7cc306139ffacbbe7
derekbruening
requested review from
abhinav92003
and removed request for
derekbruening
|
Switched reviewer for load balancing. Some of these could presumably also go to @AssadHashmi or others. |
abhinav92003
approved these changes
Dec 17, 2024
Change-Id: Ia5c9b6731374f1e9d655af769c2fb62a56a3f8e2
Change-Id: I4dd426098047a851bb9e81c7dedb62afc231e956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dd1589c modified dstack_offs in insert_push_all_registers without generating an instruction that modifies SP. So add a SUB SP, SP, #4 there, and a corresponding ADD SP, SP, #4 in insert_pop_all_registers.
This made the test client.cleancallparams pass.
Issue: #3699