i#6728 sched time stats: Fix time accounting problems #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schedule_stats tool was incorrectly counting instructions since the last context switch leading up to an idle record as all idle time. It was also failing to count the final idle record in a sequence. We fix that here by simplifying and clarifying the time accounting. While at it, a 3rd time bucket for wait time is added. Adds a better test with a mock class with deterministic time to avoid wall-clock timing problems in testing. Fixes #6728
…hed-stats-idle-time
abhinav92003
approved these changes
Apr 29, 2024
derekbruening
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schedule_stats tool was incorrectly counting instructions since the last context switch leading up to an idle record as all idle time. It was also failing to count the final idle record in a sequence. We fix that here by simplifying and clarifying the time accounting.
While at it, a 3rd time bucket for wait time is added.
Adds a better test with a mock class with deterministic time to avoid wall-clock timing problems in testing.
Fixes #6728