Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6727: Ignore wait records in record_filter #6730

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

derekbruening
Copy link
Contributor

Updates record_filter to ignore TRACE_MARKER_TYPE_CORE_WAIT records. These are artificial timing records: we do not want to output them, nor consider them real input records.

Adds a unit test.

Fixes #6727

Updates record_filter to ignore TRACE_MARKER_TYPE_CORE_WAIT records.
These are artificial timing records: we do not want to output them,
nor consider them real input records.

Adds a unit test.

Fixes #6727
@derekbruening derekbruening requested review from abhinav92003 and brettcoon and removed request for abhinav92003 March 26, 2024 20:20
Copy link
Contributor

@brettcoon brettcoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@derekbruening derekbruening merged commit 8b3f924 into master Mar 26, 2024
16 checks passed
@derekbruening derekbruening deleted the i6727-filter-no-waits branch March 26, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record_filter should not write out wait records during replay
3 participants