i#6417 AMD 32-bit: Create a denylist for CI x86-32 tests. #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankyluk
changed the title
abhinav92003
requested changes
Mar 25, 2024
| @@ -95,7 +95,7 @@ if (UNIX AND NOT APPLE AND NOT ANDROID AND NOT cross_riscv64_linux_only) | |||
| # TODO i#6417: The switch to AMD VM's for GA CI has broken many of our tests. | |||
| # This includes timeouts which increases suite length. | |||
| # Until we get ths x86-32 job back green, we drop back to a small set of tests. | |||
| set(extra_ctest_args INCLUDE_LABEL UBUNTU_22) | |||
| set(extra_ctest_args EXCLUDE_LABEL X32_BLACKLIST) | |||
There was a problem hiding this comment.
s/blacklist/denylist/
ivankyluk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a denylist for CI x86-32 tests, and move failing tests to it.
The change re-enable passing tests removed by #6590.
Issue: #6417