i#6713: Remove same-input-same-start cpu_schedule entries #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes same-input-same-start cpu_schedule entries when reading the schedule file in the scheduler. The scheduler cannot emulate a switch with no instructions in between in replay mode, and these same-start entries cause problems. Adds a scheduler unit test. Tested on a larger app in as-traced mode where there are many of these same-start entries and without this fix the scheduler advances too early, causing problems. Fixes #6713
abhinav92003
approved these changes
Mar 22, 2024
… and adjust several comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes same-input-same-start cpu_schedule entries when reading the schedule file in the scheduler. The scheduler cannot emulate a switch with no instructions in between in replay mode, and these same-start entries cause problems.
Adds a scheduler unit test.
Tested on a larger app in as-traced mode where there are many of these same-start entries and without this fix the scheduler advances too early, causing problems.
Fixes #6713