Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions on how to watch for test failures to triage docs #6610

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add instructions on how to watch for test failures to triage docs #6610

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b6f3f3
Add instructions on how to watch for test failures to triage docs
xdje42 Jan 31, 2024
33791c0
Merge branch 'master' of github.com:DynamoRIO/dynamorio into iX-triag…
xdje42 Feb 10, 2024
8a4f74a
Update instructions for how to watch merges to master
xdje42 Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/docs/triager.dox
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And remove reference to Jenkins since, while used, is done as part of a Github Action, and thus there's no separate place to look for failures.

nit: Generally the body should stand on its own, including repeating what is in the title if necessary: i.e., best to not start it with "And". The title is not always right there depending on what history tool is used.

We have a rotating Triager who is responsible for monitoring our continuous testing infrastructure and for triaging incoming requests from users. Specific duties include:

- Ensure that our Continuous Integration testing through Github Actions and Jenkins are operating smoothly.
- Ensure that our Continuous Integration testing through Github Actions are operating smoothly.
- Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions.
- If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`.
- Watch merges to master for failures on the longer test suite.
- Do this by watching for merges on the dynamorio-devs@ list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to look at the devs list. These are on the same Actions page linked above, to find details -- but the summary page is the green check or red X by each commit at https://github.com/DynamoRIO/dynamorio/commits/master/ . That's what the goal is: to have that page contain nothing but green checks.

- File an issue on previously-unknown failures, or update existing issues for repeats. Consider marking tests as flaky in `runsuite_wrapper.pl` if they are keeping the master merge red.
- Answer (or request that someone else who is more of an expert in that area answer) incoming dynamorio-users emails.
- Sometimes emails to the list are marked as spam, so it is a good idea to directly watch the web interface: https://groups.google.com/g/DynamoRIO-Users
Expand Down
Loading