i#4304 unexpected_return unreachable on aarch64: Use long branch #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix i#4304 in a different way by always using a branch/call instruction with enough bits of offset to reach the unexpected_return function. Conditional branches don't always have enough offsets to branch to any function within a binary: they're generally only intended for branching within a single function. On aarch64 conditional branch instructions have 19 bits of offset and unconditional branch and call instructions have 26 bits, and is used for every other function call so we should be good for awhile. Fixes #4304
|
The failing tests are not related to the patch. |
derekbruening
approved these changes
Jan 19, 2024
Fix i#4304 in a different way by always using a branch/call instruction with enough bits of offset to reach the unexpected_return function. Conditional branches don't always have enough offsets to branch to any function within a binary: they're generally only intended for branching within a single function. On aarch64 conditional branch instructions have 19 bits of offset and unconditional branch and call instructions have 26 bits, and are used for every other function call so we should be good for a while. Fixes #4304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix i#4304 in a different way by always using a branch/call instruction with enough bits of offset to reach the unexpected_return function. Conditional branches don't always have enough offsets to branch to any function within a binary: they're generally only intended for branching within a single function. On aarch64 conditional branch instructions have 19 bits of offset and unconditional branch and call instructions have 26 bits, and is used for every other function call so we should be good for awhile.
Fixes #4304