Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Enable sample.bbbuf test #6493

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Dec 4, 2023

This patch enables sample.bbbuf test with the following fixes:

  • x0 on RISC-V is like XZR on AArch64, so do not consider it as a general register
  • tp should be avoided in drreg_reserve_reg_internal()
  • RISC-V does not have control flags, so a dummy hello test is used for control_flags instead

Also removed linux.sigaction_nosignals and pthreads.pthreads from RUNS_ON_QEMU since they are not working on real hardware.

#3544

@ksco ksco requested a review from derekbruening December 4, 2023 16:08
@derekbruening derekbruening requested review from abhinav92003 and removed request for derekbruening December 4, 2023 19:42
suite/tests/CMakeLists.txt Show resolved Hide resolved
@ksco
Copy link
Contributor Author

ksco commented Dec 5, 2023

@abhinav92003 Can you merge this? Thanks.

@abhinav92003
Copy link
Contributor

x86-32 failures are #6417.

@abhinav92003 abhinav92003 merged commit a8cf1df into DynamoRIO:master Dec 5, 2023
14 of 15 checks passed
@ksco ksco deleted the i3544-sample-tests branch December 6, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants