i#5505 kernel tracing: Support clac and stac in DR decoder #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds encoding-decoding support for clac and stac which are observed in some kernel traces. Adds EFLAGS_READ_AC and EFLAGS_WRITE_AC to track reads/writes to the Alignment Check flag. Issue: #5505
derekbruening
approved these changes
Nov 30, 2023
|
Okay I made the bitset adjustments for eflags. Would be good to get another review. Also had to make a temporary change to the decenc test to avoid a large diff. |
derekbruening
approved these changes
Nov 30, 2023
|
x86-32 failures are #6417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds encoding-decoding support for clac and stac which are observed in some kernel traces.
decode_fast does not need any change and already should get the 3-byte size correctly.
Adds EFLAGS_READ_AC and EFLAGS_WRITE_AC to track reads/writes to the Alignment Check flag.
Currently we try to avoid a major binary compatibility break by adding them to the end. This makes
some code more complicated. Added a TODO with #6485 to re-number when we're about to do the
next major release.
Issue: #5505
Fixes: #2103