i#6416: Replace vdso raw bytes with per-block encodings #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the vdso raw bytes we were storing in the module file for offline drmemtraces. Switches to using per-block encodings instead. This avoids problems with hooked vsysenter on 32-bit AMD. Tested on tool.drcacheoff.simple on 32-bit AMD on a machine where that test failed every time before this fix. Removes the unused offline_instru_t::get_modoffs() rather than updating it for the vdso change. Fixes #6416
|
win64 is traceopts #6423 |
abhinav92003
approved these changes
Nov 17, 2023
|
The x32 failure is the set from #6417. That seems to be the remaining failure that is happening nearly every time now (more AMD machines for GA I guess). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the vdso raw bytes we were storing in the module file for offline drmemtraces. Switches to using per-block encodings instead. This avoids problems with hooked vsysenter on 32-bit AMD.
Tested on tool.drcacheoff.simple on 32-bit AMD on a machine where that test failed every time before this fix.
Removes the unused offline_instru_t::get_modoffs() rather than updating it for the vdso change.
Issue: #6416, #2062
Fixes #6416