Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#2267 utils.cmake: Use <unknown> for cpu_vendor as fallback #6457

Merged
merged 2 commits into from
Nov 16, 2023
Merged

i#2267 utils.cmake: Use <unknown> for cpu_vendor as fallback #6457

merged 2 commits into from
Nov 16, 2023

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Nov 15, 2023 •
edited
Loading

vendor_id is not always available, only do REGEX REPLACE if a match is found. Tested on Intel, AMD, and <unknown> AArch64 machines via GA runners.

Issue: #2267

@ksco
i#2267 utils.cmake: Use <unknown> for cpu_vendor as fallback
e8e042b 
`vendor_id` is not always available, only do `REGEX REPLACE` it a match if found.

Issue: DynamoRIO#2267
@ksco ksco requested a review from derekbruening November 15, 2023 07:26
derekbruening
derekbruening approved these changes Nov 15, 2023
View reviewed changes
make/utils.cmake Show resolved Hide resolved
@ksco
Copy link
Contributor Author

ksco commented Nov 16, 2023

x86-32-ubuntu22 #6416 and x86-32 #6417 failed 5 times in a row.

@derekbruening
Copy link
Contributor

x86-32-ubuntu22 #6416 and x86-32 #6417 failed 5 times in a row.

Any help on #6417 is appreciated. Meanwhile I will merge this.

@derekbruening derekbruening merged commit 81fdbd7 into DynamoRIO:master Nov 16, 2023
13 of 15 checks passed
@ksco ksco deleted the i2267-cpu-vendor-fallback branch November 16, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbruening derekbruening derekbruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksco @derekbruening