i#3348 sym conflicts: add DR_PARAM_ to IN, OUT, INOUT #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid symbol conflicts with IN, OUT, and INOUT, which are defined in our exported headers, we add DR_PARAM_ to the front. Issue: #3348
…assumes single-line signatures
|
Failures were all known flakes; re-ran them. The DO NOT CHECK IN disabling the clang-format-diff will be reverted right before commit: it fails b/c of clang-format-diff not matching full clang-format in a few places. I've hit some of these before and reverted the format on those prior merges, but here we're just going to put in the full new format and avoid future problems. |
ivankyluk
approved these changes
Nov 14, 2023
This reverts commit a8901e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid symbol conflicts with IN, OUT, and INOUT, which are defined in our exported headers, we add DR_PARAM_ to the front.
The aarch64 codec.c was left as the shorter names since the aarch64_check_codec_order.py assumes single-line signatures.
Issue: #3348