-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#6444 no exit: Add invariant check for thread exit #6445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an invariant check that each thread has an exit record in a drmemtrace. Adds a unit test. The new check failed on nearly every existing unit test, requiring adding thread exits. That in turn triggered exit checks on missing headers and filetypes. I ended up having to edit every test case. As part of this I standardized the tid constants used. Issue: #6444
…xit record; Fix a64 test and windows build
x32 is set in #6417 |
ivankyluk
reviewed
Nov 13, 2023
ivankyluk
reviewed
Nov 13, 2023
ivankyluk
approved these changes
Nov 13, 2023
4 jobs failing, all with known failures:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an invariant check that each thread has an exit record in a drmemtrace.
Adds a path for the analyzer to call process_shard_exit() when there is no exit record.
Manually tested this on a real truncated trace.
Adds a unit test.
The new check failed on nearly every existing unit test, requiring adding thread exits. That in turn triggered exit checks on missing headers and filetypes. I ended up having to edit every test case. As part of this I standardized the tid constants used.
Issue: #6444