Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6444 no exit: Add invariant check for thread exit #6445

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

derekbruening
Copy link
Contributor

@derekbruening derekbruening commented Nov 10, 2023

Adds an invariant check that each thread has an exit record in a drmemtrace.

Adds a path for the analyzer to call process_shard_exit() when there is no exit record.
Manually tested this on a real truncated trace.

Adds a unit test.

The new check failed on nearly every existing unit test, requiring adding thread exits. That in turn triggered exit checks on missing headers and filetypes. I ended up having to edit every test case. As part of this I standardized the tid constants used.

Issue: #6444

Adds an invariant check that each thread has an exit record in a
drmemtrace.

Adds a unit test.

The new check failed on nearly every existing unit test, requiring
adding thread exits.  That in turn triggered exit checks on missing
headers and filetypes.  I ended up having to edit every test case.  As
part of this I standardized the tid constants used.

Issue: #6444
@derekbruening
Copy link
Contributor Author

ub22 is off.simple #6416
win64: traceopts #6423, replaceall #5412

@derekbruening
Copy link
Contributor Author

x32 is set in #6417

@derekbruening derekbruening merged commit ecba9eb into master Nov 13, 2023
11 of 15 checks passed
@derekbruening derekbruening deleted the i6444-check-exit-found branch November 13, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants