-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#3544 RV64: Fill in the missing pieces to run actual programs #6437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fills in many missing pieces related to RISC-V porting. Although our philosophy is to keep patches as small as possible, IMHO these pieces would be painful to submit individually. With this patch, plus one more patch to mangle.c yet to be submitted, we are finally able to run some programs, which means some tests can be enabled/ported for RISC-V and more RISC-V specific tests can be written.
Although our philosophy is to keep patches as small as possible, IMHO these pieces would be painful to submit individually. |
derekbruening
requested review from
abhinav92003
and removed request for
derekbruening
November 10, 2023 01:08
abhinav92003
approved these changes
Nov 10, 2023
x86-64-ubuntu22 api.rseq failed: #6185 |
x86-64 common.floatpc_xl8all failed: #2267 |
x86-32 81 tests failed: #6417 |
Never mind, more stable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fills in many missing pieces related to RISC-V porting.
With this patch, plus one more patch to mangle.c yet to be submitted, we are finally able to run some programs, which means some tests can be enabled/ported for RISC-V and more RISC-V specific tests can be written.
Issue: #3544