Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Fill in the missing pieces to run actual programs #6437

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

ksco
Copy link
Contributor

@ksco ksco commented Nov 9, 2023

This patch fills in many missing pieces related to RISC-V porting.

With this patch, plus one more patch to mangle.c yet to be submitted, we are finally able to run some programs, which means some tests can be enabled/ported for RISC-V and more RISC-V specific tests can be written.

Issue: #3544

This patch fills in many missing pieces related to RISC-V porting.

Although our philosophy is to keep patches as small as possible, IMHO these pieces would be painful to submit individually.

With this patch, plus one more patch to mangle.c yet to be submitted, we are finally able to run some programs, which means some tests can be enabled/ported for RISC-V and more RISC-V specific tests can be written.
@ksco ksco requested a review from derekbruening November 9, 2023 19:08
@ksco
Copy link
Contributor Author

ksco commented Nov 9, 2023

Although our philosophy is to keep patches as small as possible, IMHO these pieces would be painful to submit individually.

@derekbruening derekbruening requested review from abhinav92003 and removed request for derekbruening November 10, 2023 01:08
core/arch/interp.c Outdated Show resolved Hide resolved
core/arch/mangle_shared.c Outdated Show resolved Hide resolved
core/fragment.h Outdated Show resolved Hide resolved
core/unix/loader_linux.c Outdated Show resolved Hide resolved
@ksco
Copy link
Contributor Author

ksco commented Nov 10, 2023

x86-64-ubuntu22 api.rseq failed: #6185

@ksco
Copy link
Contributor Author

ksco commented Nov 10, 2023

x86-64 common.floatpc_xl8all failed: #2267

@ksco
Copy link
Contributor Author

ksco commented Nov 10, 2023

x86-32 81 tests failed: #6417

@ksco
Copy link
Contributor Author

ksco commented Nov 10, 2023

x86-64 and x86-32 failed again on a second try, @abhinav92003 may I borrow your admin power? 😈

Never mind, more stable now.

@ksco ksco merged commit c6f7b74 into DynamoRIO:master Nov 11, 2023
15 checks passed
@ksco ksco deleted the i3544-last-piece branch November 11, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants