i#6411 runcmp: Use external diff on failure if possible #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `find_program` to detect presence of the external diff command and, if such a command is detected, print a full diff on failure to ease debugging. Issue: DynamoRIO#6411 Related PR: DynamoRIO#6254
|
Now we have the diff output: https://github.com/DynamoRIO/dynamorio/actions/runs/6807093606/job/18509368067?pr=6428#step:7:27881 |
Good, so it does look like #6411 is the same as #5725! Though we still don't understand the cause of the failure...trying to get tmate on it. |
derekbruening
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
find_programto detect presence of the external diff command and, if such a command is detected, print a full diff on failure to ease debugging.Issue: #6411
Related PR: #6254