i#3544 RV64: Implement tp, stolen reg and lr/sc sequence mangling #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements several mangling procedures for tp, stored reg, and lr/sc sequences. 1. For any instruction using tp or stolen register, we use a scratch register to hold the app value, and mangling the instr to use that scratch register. 2. For the lr/sc sequence, a similar approach to AARCHXX's exclusive monitor is adopted: mangling LR to a normal load, and SC to a compare-and-swap. The function name (mangle_exclusive_monitor_op) is keeped unchanged for simplicity. Note there are several places that are left unimplemented, they are rarely used in practice, so it should be okay to implement it later.
ksco
commented
Nov 9, 2023
derekbruening
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements several mangling procedures for tp, stolen reg, and lr/sc sequences.
Note there are several places that are left unimplemented, they are rarely used in practice, so it should be okay to implement it later.
Issue: #3544