-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#3101 drcachesim: add binary interface for running separately-built analysis tools #6335
i#3101 drcachesim: add binary interface for running separately-built analysis tools #6335
Conversation
…analysis tools - Added support of loading analysis tools to drcachesim dynamically - Added opportunity to run multiple simulators simultaniously Issue: DynamoRIO#3101
Looks like there are still some build issues breaking some platforms. Please indicate when this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. This is a nice feature. I mostly have a bunch of minor style comments; nothing major beyond adding more docs and adding a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some spelling/writing nits.
In the future, please reply to each comment with "Done" or something similar, rather than just marking resolved with no reply, as documented: https://dynamorio.org/page_code_reviews.html#autotoc_md114 |
Fixes un-escaped quote characters from PR #6335 which show up as CMake warnings.
This pull request includes the following functionality:
Issue: #3101