Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3101 drcachesim: add binary interface for running separately-built analysis tools #6335

Merged

Conversation

yuriershov
Copy link
Contributor

This pull request includes the following functionality:

  • Added support of loading separately-built analysis tools to drcachesim dynamically
  • Added opportunity to run multiple simulators simultaneously

Issue: #3101

…analysis tools

 - Added support of loading analysis tools to drcachesim dynamically
 - Added opportunity to run multiple simulators simultaniously

Issue: DynamoRIO#3101
@derekbruening
Copy link
Contributor

Looks like there are still some build issues breaking some platforms. Please indicate when this is ready for review.

Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. This is a nice feature. I mostly have a bunch of minor style comments; nothing major beyond adding more docs and adding a test.

clients/drcachesim/docs/drcachesim.dox.in Show resolved Hide resolved
clients/drcachesim/CMakeLists.txt Outdated Show resolved Hide resolved
clients/drcachesim/analyzer_multi.cpp Outdated Show resolved Hide resolved
clients/drcachesim/analyzer_multi.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tools/loader/external_tool_creator.h Outdated Show resolved Hide resolved
clients/drcachesim/tools/loader/external_tool_creator.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tools/loader/external_tool_creator.cpp Outdated Show resolved Hide resolved
clients/drcachesim/analyzer_multi.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some spelling/writing nits.

clients/drcachesim/docs/drcachesim.dox.in Outdated Show resolved Hide resolved
clients/drcachesim/docs/drcachesim.dox.in Outdated Show resolved Hide resolved
clients/drcachesim/docs/drcachesim.dox.in Outdated Show resolved Hide resolved
clients/drcachesim/tools/external/example/CMakeLists.txt Outdated Show resolved Hide resolved
clients/drcachesim/tools/external/example/CMakeLists.txt Outdated Show resolved Hide resolved
clients/drcachesim/tools/external/example/empty.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tools/external/example/empty.h Outdated Show resolved Hide resolved
clients/drcachesim/tools/loader/external_tool_creator.h Outdated Show resolved Hide resolved
@yuriershov yuriershov merged commit ac3b3fb into DynamoRIO:master Oct 9, 2023
15 checks passed
@derekbruening
Copy link
Contributor

In the future, please reply to each comment with "Done" or something similar, rather than just marking resolved with no reply, as documented: https://dynamorio.org/page_code_reviews.html#autotoc_md114

derekbruening added a commit that referenced this pull request Oct 10, 2023
Fixes un-escaped quote characters from PR #6335 which show up as CMake
warnings.
derekbruening added a commit that referenced this pull request Oct 12, 2023
Fixes un-escaped quote characters from PR #6335 which show up as CMake
warnings.

Issue: #3101
derekbruening added a commit that referenced this pull request Oct 12, 2023
Fixes un-escaped quote characters from PR #6335 which show up as CMake
warnings.

Issue: #3101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants