i#6303: Avoid duplicate encoding entry on chunk-split branch pair #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a case where a branch followed by an indirect branch with a chunk split in the middle results in an extra encoding entry after the indirect branch target marker. This extra entry is accumulated in the reader and results in a fatal error. Adds a unit test. Confirmed the fix on the drcacheoff.invariant_checker test as well where it was failing reliably on one machine. Fixes #6303
abhinav92003
approved these changes
Sep 20, 2023
…oid a duplicate encoding on the next dynamic instance post-chunk; also apply review requestson name changes and comment updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where a branch followed by an indirect branch with a chunk split in the middle results in an extra encoding entry after the indirect branch target marker. This extra entry is accumulated in the reader and results in a fatal error.
Adds a unit test. Confirmed the fix on the
drcacheoff.invariant_checker test as well where it was failing reliably on one machine.
Fixes #6303