i#5329: Fix tool.drcachesim.scattergather-x86 test failure #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids going over the atomic write size while waiting for enough entries to write to IPC pipe. If we find we went over, we just write till the last ok-to-split ref. Fixes: #5329
derekbruening
approved these changes
Sep 18, 2023
abhinav92003
commented
Sep 18, 2023
abhinav92003
changed the title
|
x86-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids going over the atomic write size while waiting for enough entries to write to IPC pipe. If we find we went over, we just write till the last ok-to-split ref.
tool.drcachesim.scattergather-x86 worked fine 100x on local workstation with this fix.
This issue manifests on this test because some scatter-gather instruction has eight consecutive memrefs which puts us over the threshold suddenly without any opportunity to write the buffer before all the memrefs.
Fixes: #5329