PR feedback. Remove unnecessary if statement.

DynamoRIO · Sep 20, 2023 · e1c348d · e1c348d
1 parent 1908cbe
commit e1c348d
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/clients/drcachesim/tools/invariant_checker.cpp b/clients/drcachesim/tools/invariant_checker.cpp
@@ -531,12 +531,9 @@ invariant_checker_t::parallel_shard_memref(void *shard_data, const memref_t &mem
                 instr_noalloc_t noalloc;
                 instr_noalloc_init(drcontext_, &noalloc);
                 instr_t *noalloc_instr = instr_from_noalloc(&noalloc);
-                app_pc next_pc = decode_from_copy(
-                    drcontext_, const_cast<app_pc>(memref.instr.encoding), trace_pc,
-                    noalloc_instr);
-                if (next_pc == nullptr) {
-                    noalloc_instr = nullptr;
-                }
+                decode_from_copy(drcontext_, const_cast<app_pc>(memref.instr.encoding),
+                                 trace_pc, noalloc_instr);
+
                 // Add decoding attributes to cur_instr_info.
                 if (noalloc_instr != nullptr) {
                     cur_instr_info.decoding.has_valid_decoding = true;