Skip to content

Commit

Permalink
Remove debug logs and fix bug.
Browse files Browse the repository at this point in the history
  • Loading branch information
abhinav92003 committed Nov 22, 2023
1 parent ba3c6e7 commit d35869c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,6 @@ jobs:
CI_TRIGGER: ${{ github.event_name }}
CI_BRANCH: ${{ github.ref }}

- name: Setup tmate session
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3

- name: Send failure mail to dynamorio-devs
if: failure() && github.ref == 'refs/heads/master'
uses: dawidd6/action-send-mail@v2
Expand Down
8 changes: 2 additions & 6 deletions clients/drcachesim/tracer/raw2trace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
#include <cstring>
#include <deque>
#include <iomanip>
#include <iostream>
#include <memory>
#include <sstream>
#include <string>
Expand Down Expand Up @@ -351,7 +350,7 @@ module_mapper_t::do_encoding_parsing()
if (map_start == nullptr || map_size < file_size)
return "Failed to map encoding file";
byte *map_at = map_start;
byte *map_end = map_start + map_size;
byte *map_end = map_start + file_size;
uint64_t encoding_file_version = *reinterpret_cast<uint64_t *>(map_at);
map_at += sizeof(uint64_t);
if (encoding_file_version > ENCODING_FILE_VERSION)
Expand All @@ -365,11 +364,8 @@ module_mapper_t::do_encoding_parsing()
uint64_t cumulative_encoding_length = 0;
while (map_at < map_end) {
encoding_entry_t *entry = reinterpret_cast<encoding_entry_t *>(map_at);
if (entry->length < sizeof(encoding_entry_t)) {
std::cerr << "AAA entry->length: " << entry->length << " sizeof "
<< sizeof(encoding_entry_t) << "\n";
if (entry->length < sizeof(encoding_entry_t))
return "Encoding file is corrupted";
}
if (map_at + entry->length > map_end)
return "Encoding file is truncated";
cum_block_enc_len_to_encoding_id_[cumulative_encoding_length] = entry->id;
Expand Down

0 comments on commit d35869c

Please sign in to comment.