Comment clarifications.

DynamoRIO · Dec 8, 2023 · 9cb2820 · 9cb2820
1 parent 9f11cf4
commit 9cb2820
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/clients/drcachesim/common/trace_entry.h b/clients/drcachesim/common/trace_entry.h
@@ -921,7 +921,8 @@ typedef enum {
      * a separate component. This will make it easier to manually append, update, or
      * inspect the individual templates, and also allow streaming the component with the
      * required template when needed instead of reading the complete file into memory
-     * ahead of time.
+     * ahead of time. Note that we may drop support for non-zipfile template files in
+     * the future.
      */
     OFFLINE_FILE_TYPE_KERNEL_SYSCALL_TRACE_TEMPLATES = 0x4000,
 } offline_file_type_t;

diff --git a/clients/drcachesim/tests/burst_syscall_inject.cpp b/clients/drcachesim/tests/burst_syscall_inject.cpp
@@ -301,8 +301,6 @@ look_for_syscall_trace(void *dr_context, std::string trace_dir)
             case TRACE_MARKER_TYPE_SYSCALL_TRACE_START:
                 syscall_trace_num = memref.marker.marker_value;
                 if (syscall_trace_num != prev_syscall_num_marker_saved ||
-                    // We assume there would not be a chunk split between the sysnum
-                    // marker and the trace start marker for this short trace.
                     prev_syscall_num_marker_saved == -1) {
                     std::cerr << "Found unexpected trace for system call "
                               << syscall_trace_num