Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compiler warnings (-Wall -Wpedantic) #880

Open
wants to merge 3 commits into
base: dev2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHOLMOD/Check/cholmod_check.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ static int check_common
//--------------------------------------------------------------------------

RETURN_IF_NULL_COMMON (FALSE) ;
int init_print = print ;

P2 ("%s", "\n") ;

Expand Down
1 change: 0 additions & 1 deletion CHOLMOD/Cholesky/cholmod_analyze.c
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,6 @@ cholmod_factor *CHOLMOD(analyze_p2)
//--------------------------------------------------------------------------

n = A->nrow ;
ncol = A->ncol ;

//--------------------------------------------------------------------------
// set the default strategy
Expand Down
1 change: 0 additions & 1 deletion CHOLMOD/Cholesky/t_cholmod_resymbol_worker.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ static void TEMPLATE (cholmod_resymbol_worker)
Int *Ap = A->p ;
Int *Anz = A->nz ;
bool apacked = A->packed ;
bool sorted = A->sorted ;
int stype = A->stype ;

Int *Li = L->i ;
Expand Down
1 change: 0 additions & 1 deletion CHOLMOD/Modify/cholmod_rowadd.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ int CHOLMOD(rowadd_mark)
RETURN_IF_NULL (R, FALSE) ;
RETURN_IF_XTYPE_INVALID (L, CHOLMOD_PATTERN, CHOLMOD_REAL, FALSE) ;
RETURN_IF_XTYPE_INVALID (R, CHOLMOD_REAL, CHOLMOD_REAL, FALSE) ;
Int n = L->n ;
Int k = kadd ;
if (kadd >= L->n || k < 0)
{
Expand Down
1 change: 0 additions & 1 deletion CHOLMOD/Modify/cholmod_rowdel.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ int CHOLMOD(rowdel_mark)
RETURN_IF_NULL_COMMON (FALSE) ;
RETURN_IF_NULL (L, FALSE) ;
RETURN_IF_XTYPE_INVALID (L, CHOLMOD_PATTERN, CHOLMOD_REAL, FALSE) ;
Int n = L->n ;
Int k = kdel ;
if (kdel >= L->n || k < 0)
{
Expand Down
26 changes: 13 additions & 13 deletions LAGraph/src/utility/LAGraph_Vector_Print.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,21 @@ int LG_Vector_Print_ ## suffix \
return (GrB_SUCCESS) ; \
}

LG_VECTOR_PRINT (BOOL , bool , GrB_BOOL , "%d" , "%d" ) ;
LG_VECTOR_PRINT (INT8 , int8_t , GrB_INT8 , "%d" , "%d" ) ;
LG_VECTOR_PRINT (INT16 , int16_t , GrB_INT16 , "%d" , "%d" ) ;
LG_VECTOR_PRINT (INT32 , int32_t , GrB_INT32 , "%" PRId32, "%" PRId32 ) ;
LG_VECTOR_PRINT (INT64 , int64_t , GrB_INT64 , "%" PRId64, "%" PRId64 ) ;
LG_VECTOR_PRINT (UINT8 , uint8_t , GrB_UINT8 , "%d" , "%d" ) ;
LG_VECTOR_PRINT (UINT16, uint16_t, GrB_UINT16, "%d" , "%d" ) ;
LG_VECTOR_PRINT (UINT32, uint32_t, GrB_UINT32, "%" PRIu32, "%" PRIu32 ) ;
LG_VECTOR_PRINT (UINT64, uint64_t, GrB_UINT64, "%" PRIu64, "%" PRIu64 ) ;
LG_VECTOR_PRINT (FP32 , float , GrB_FP32 , "%g" , "%0.7g" ) ;
LG_VECTOR_PRINT (FP64 , double , GrB_FP64 , "%g" , "%0.15g") ;
LG_VECTOR_PRINT (BOOL , bool , GrB_BOOL , "%d" , "%d" )
LG_VECTOR_PRINT (INT8 , int8_t , GrB_INT8 , "%d" , "%d" )
LG_VECTOR_PRINT (INT16 , int16_t , GrB_INT16 , "%d" , "%d" )
LG_VECTOR_PRINT (INT32 , int32_t , GrB_INT32 , "%" PRId32, "%" PRId32 )
LG_VECTOR_PRINT (INT64 , int64_t , GrB_INT64 , "%" PRId64, "%" PRId64 )
LG_VECTOR_PRINT (UINT8 , uint8_t , GrB_UINT8 , "%d" , "%d" )
LG_VECTOR_PRINT (UINT16, uint16_t, GrB_UINT16, "%d" , "%d" )
LG_VECTOR_PRINT (UINT32, uint32_t, GrB_UINT32, "%" PRIu32, "%" PRIu32 )
LG_VECTOR_PRINT (UINT64, uint64_t, GrB_UINT64, "%" PRIu64, "%" PRIu64 )
LG_VECTOR_PRINT (FP32 , float , GrB_FP32 , "%g" , "%0.7g" )
LG_VECTOR_PRINT (FP64 , double , GrB_FP64 , "%g" , "%0.15g")
#if 0
// would need to pass in an iscomplex flag to print creal(x) and cimag(x)
LG_VECTOR_PRINT (FC32 , GxB_FC32_t, GxB_FC32, ...) ;
LG_VECTOR_PRINT (FC64 , GxB_FC64_t, GxB_FC64, ...) ;
LG_VECTOR_PRINT (FC32 , GxB_FC32_t, GxB_FC32, ...)
LG_VECTOR_PRINT (FC64 , GxB_FC64_t, GxB_FC64, ...)
#endif

#undef LG_FREE_WORK
Expand Down
1 change: 0 additions & 1 deletion SPEX/Python/SPEXpy/Source/spex_python_connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ SPEX_info spex_python

SPEX_options option = NULL;
SPEX_create_default_options(&option);
SPEX_preorder order_in = ordering;
option->order = ordering;

//--------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion SPEX/SPEX_Utilities/Source/spex_gmp.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ int64_t spex_get_gmp_ntrials (void) ;
// uncomment this to print memory debugging info
// #define SPEX_GMP_MEMORY_DEBUG

int spex_gmp_initialize (int primary) ;
SPEX_info spex_gmp_initialize (int primary) ;

void spex_gmp_finalize (int primary) ;

Expand Down
Loading