Support optional installation based on selected components #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing a component name or a component boolean expression, only those components that have been selected by the user will be downloaded and installed. By calling the Dependency_DeselectComponent function instead of Dependency_Add in the else case of your "already installed" check, your component will automatically be deselected in the component selection page (follow the argument format of WizardSelectComponents).
Repository owner
deleted a comment from
mushramb0
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes we made to support optional installation based on component selection. We don't expect this to be merged as is, but maybe it's useful to someone or good as a starting point.
This is a bit of a breaking change, since Inno's "Pascal Script" doesn't support default arguments or overloads. Maybe someone has a better suggestion on how to accomplish this.
This change only really useful for custom dependencies at the moment, as all the default
Dependency_Add...functions would have to be updated to accept optional component arguments too.