FIX #31643 Busy resources can be used by multiple events in the same time frame. #31644

EnjoyFelix · 2024-10-30T14:02:50Z

FIX #31643 Busy resources can be used by multiple events in the same time frame.

Fixes resources not being taken into account when creating a new event from the event creation page.
Fixes assigning busy resources to multiple events at the same time

modifié : core/lib/resource.lib.php

Previously, a check for the availibility of a resource from 10h00 to 11h00 would fail if the resource was busy from 9h00 to 10h00. It makes more sense in this context to have the upper bound of the first interval to be open.

htdocs/core/lib/resource.lib.php

…b->plimit`;

…of a list of ressources mapped to their respective ids. This makes the function more usable in other contexts.

…fication page

…n page

Elisée Chemin added 9 commits October 14, 2024 10:54

Prevented the creation of events that use unavailable resources

13eac8c

Moved the busy resource query in the resource lib

831f4fa

Removed the code block introduced by the cherrypick of 13eac8c

25106e7

modifié : core/lib/resource.lib.php

Fixed an issue where the assigned resources weren't checked properly

ce5e4b4

Modified the condition to get busy resources.

83b47f6

Previously, a check for the availibility of a resource from 10h00 to 11h00 would fail if the resource was busy from 9h00 to 10h00. It makes more sense in this context to have the upper bound of the first interval to be open.

Precommit hooks

2dbab5c

Phan - missing parameter types.

002fbff

fixup! Phan - missing parameter types.

9f3970d

Phan - wrong return type

928123a

EnjoyFelix changed the title ~~Prevent busy resources from being used by multiple events in the same time frame (20.x)~~ FIX #31643 Busy resources can be used by multiple events in the same time frame. Oct 30, 2024

eldy reviewed Oct 31, 2024

View reviewed changes

htdocs/core/lib/resource.lib.php Outdated Show resolved Hide resolved

eldy reviewed Oct 31, 2024

View reviewed changes

htdocs/core/lib/resource.lib.php Outdated Show resolved Hide resolved

eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Oct 31, 2024

Elisée Chemin added 5 commits November 4, 2024 09:09

Renamed the function to use the camel case syntax and implemented `$d…

b070870

…b->plimit`;

getBusyResourcesInPeriod's $resource_ids is now a list of id instead …

de56510

…of a list of ressources mapped to their respective ids. This makes the function more usable in other contexts.

Parity change on assigning a resource to an event from the event modi…

8db5a85

…fication page

Parity change on editing a linked resource from the event modificatio…

d92a3ad

…n page

Precommit typo

ed55627

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX #31643 Busy resources can be used by multiple events in the same time frame. #31644

FIX #31643 Busy resources can be used by multiple events in the same time frame. #31644

EnjoyFelix commented Oct 30, 2024

FIX #31643 Busy resources can be used by multiple events in the same time frame. #31644

Are you sure you want to change the base?

FIX #31643 Busy resources can be used by multiple events in the same time frame. #31644

Conversation

EnjoyFelix commented Oct 30, 2024

FIX #31643 Busy resources can be used by multiple events in the same time frame.