Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qual ticket class #30787

Merged
merged 8 commits into from
Aug 31, 2024
Merged

Qual ticket class #30787

merged 8 commits into from
Aug 31, 2024

Conversation

W1W1-M
Copy link
Contributor

@W1W1-M W1W1-M commented Aug 28, 2024

Qual ticket class

  • Updated PHPDoc
  • Cleaned code(unnecessary logic, variables)

@mdeweerd
Copy link
Contributor

I can only add messages for lines that changed, so I'll comment here to help fix phan notices:

One technique is to cast the value:

strtolower((string) $info_sendto['libelle'])

Phan does not keep track that $info_sendto['email'] is empty, so my technique is to assign that to a variable and test the variable.

Here we already tested the value is not '' in the previous if.

$email=$info_sendto['email']

if ($email != null) { // or !== null

   $array[$email] = ...

@W1W1-M
Copy link
Contributor Author

W1W1-M commented Aug 30, 2024

@mdeweerd thanks for hep 😃

@eldy eldy merged commit a257f6a into Dolibarr:develop Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants