NEW Module to setup OpenID Connect module #30317
Open
+580
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import openid connect custom module phase 2
…n page path fix, add a field to set MAIN_AUTHENTICATION_OIDC_LOGIN_CLAIM
eldy
reviewed
Jul 10, 2024
eldy
reviewed
Jul 10, 2024
eldy
reviewed
Jul 10, 2024
eldy
added
the
PR to fix or conflict to solve
eldy
reviewed
Jul 16, 2024
| @@ -887,7 +887,7 @@ function analyseVarsForSqlAndScriptsInjection(&$var, $type, $stopcode = 1) | |||
| if (GETPOST("username", "alpha", $allowedmethodtopostusername)) { // For posting the login form | |||
| $goontestloop = true; | |||
| } | |||
| if (GETPOST('openid_mode', 'alpha', 1)) { // For openid_connect ? | |||
| if (GETPOST('openid_mode', 'alpha')) { // For openid_connect ? | |||
There was a problem hiding this comment.
Can you confirm we must remove the parameter ",1" here ?
There was a problem hiding this comment.
This is to allow POST, this is used on the form inside 'callback.php'
We want to prevent the argument to stay in the URL when a user doesn't change page after login. When a new OpenID authentication is needed and this parameter is still present in the URL this cause an error since it's awaiting the code parameter if this parameter is present and the user not logged.
eldy
added
Discussion
eldy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
OpenID Connect as a standard module