NEW add company type on filter #30267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jul 4, 2024
htdocs/compta/stats/casoc.php
Outdated
| print ' '; | ||
| print $langs->trans("Type").': '; | ||
| $formcompany = new FormCompany($db); | ||
| $sortparam = (empty($conf->global->SOCIETE_SORT_ON_TYPEENT) ? 'ASC' : $conf->global->SOCIETE_SORT_ON_TYPEENT); // NONE means we keep sort of original array, so we sort on position. ASC, means next function will sort on label. |
There was a problem hiding this comment.
Use of $conf->global-> is forbidden. Use getDolGlobal...
There was a problem hiding this comment.
sorry, i have made this ugrade for a customer on 14.0.5 ...
eldy
added
the
PR to fix or conflict to solve
defrance
commented
Jul 5, 2024
htdocs/compta/stats/casoc.php
Outdated
| print ' '; | ||
| print $langs->trans("Type").': '; | ||
| $formcompany = new FormCompany($db); | ||
| $sortparam = (empty($conf->global->SOCIETE_SORT_ON_TYPEENT) ? 'ASC' : $conf->global->SOCIETE_SORT_ON_TYPEENT); // NONE means we keep sort of original array, so we sort on position. ASC, means next function will sort on label. |
There was a problem hiding this comment.
sorry, i have made this ugrade for a customer on 14.0.5 ...
eldy
reviewed
Jul 6, 2024
| // type filter (produit/service) | ||
| print ' '; | ||
| print ' '; | ||
| print $langs->trans("Type").': '; |
There was a problem hiding this comment.
In look and feel of recent version, labels of filters must be included as the placeholder of the combobox (to move into the param$shwo_empty of selectarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.