New updating for preview php content #30155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jun 29, 2024
| @@ -0,0 +1,58 @@ | |||
| <?php | |||
There was a problem hiding this comment.
This is the ajax service i think ?
If i am right, move the file into directory htdocs/core/ajax/emailingemplates.php.
eldy
reviewed
Jun 29, 2024
| top_httphead(); | ||
|
|
||
| if ($_SERVER['REQUEST_METHOD'] == 'POST' && GETPOSTISSET('content')) { | ||
| $content = $_POST['content']; |
There was a problem hiding this comment.
$_POST use is forbidden.
You must use GETPOST()
eldy
reviewed
Jun 29, 2024
|
|
||
| $i = 0; | ||
| do { | ||
| $filePath = $directory . '/template_' . $i++ . '.php'; |
There was a problem hiding this comment.
The $directory = DOL_DATA_ROOT . '/mailing/email_template';
is inside the root where binary files are stored. It means the directory should be in readonly mode and is not writable by the web server on a secured installation.
Any temporaty files must be stored into a temp directory.
For example, you can use $conf->admin->dir_temp
eldy
added
the
PR to fix or conflict to solve
lamrani002
removed
the
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New updating for preview php content on Ckeditor
for exemple preview news :
