Fix & enable PhanTypeInvalidRightOperandOfNumericOp

dev/tools/phan/baseline.txt

@@ -47,7 +47,7 @@ return [
         'htdocs/core/lib/functions.lib.php' => ['PhanParamTooMany', 'PhanRedefineFunctionInternal'],
         'htdocs/core/lib/price.lib.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/core/modules/movement/doc/pdf_standard.modules.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
-        'htdocs/core/modules/mrp/doc/pdf_vinci.modules.php' => ['PhanTypeArraySuspiciousNull'],
+        'htdocs/core/modules/mrp/doc/pdf_vinci.modules.php' => ['PhanTypeArraySuspiciousNull', 'PhanTypeInvalidRightOperandOfAdd'],
         'htdocs/core/modules/syslog/mod_syslog_file.php' => ['PhanParamSignatureMismatch'],
         'htdocs/core/modules/syslog/mod_syslog_syslog.php' => ['PhanParamSignatureMismatch'],
         'htdocs/don/class/don.class.php' => ['PhanParamTooMany'],

dev/tools/phan/config.php

@@ -463,7 +463,7 @@
 		// 'PhanTypeMismatchPropertyProbablyReal',
 		// 'PhanPluginNoCommentOnPrivateMethod',
 		'PhanPluginUnknownArrayFunctionReturnType',
-		'PhanTypeInvalidLeftOperandOfAdd',
+		// 'PhanTypeInvalidLeftOperandOfAdd',
 		// 'PhanPluginNoCommentOnPrivateProperty',
 		// 'PhanPluginNoCommentOnFunction',
 		'PhanPluginUnknownArrayFunctionParamType',
@@ -473,14 +473,14 @@
 		// 'PhanPluginRedundantAssignment',
 
 		'PhanTypeExpectedObjectPropAccess',
-		'PhanTypeInvalidRightOperandOfNumericOp',
+		// 'PhanTypeInvalidRightOperandOfNumericOp',
 		// 'PhanPluginInlineHTML',
 		// 'PhanPluginInlineHTMLTrailing',
 		// 'PhanPluginUnknownFunctionReturnType',
 		// 'PhanPluginDescriptionlessCommentOnProtectedProperty',
 		'PhanPluginRedundantAssignmentInGlobalScope',
 		// 'PhanTypeMismatchDeclaredParamNullable',
-		'PhanTypeInvalidRightOperandOfAdd',
+		// 'PhanTypeInvalidRightOperandOfAdd',
 		// 'PhanPluginDescriptionlessCommentOnPrivateProperty',
 		// 'PhanUndeclaredVariableDim',  // Array initialisation on undeclared var: $abc['x']='ab'
 		'PhanTypeInvalidPropertyName',
@@ -600,15 +600,15 @@
 		// 'PhanPluginUnreachableCode',
 		// 'PhanTypeMismatchArgumentInternal',
 		// 'PhanPluginAlwaysReturnMethod',
-		'PhanUndeclaredClassMethod',
+		// 'PhanUndeclaredClassMethod',
 		'PhanUndeclaredMethod',
 		'PhanTypeMismatchArgumentProbablyReal',
 		'PhanPluginDuplicateExpressionAssignmentOperation',  // Suggestions for optimisation
 		// 'PhanTypeMismatchPropertyDefault',
 		// 'PhanPluginAlwaysReturnMethod',
 		// 'PhanPluginMissingReturnMethod',
 		// 'PhanUndeclaredTypeReturnType',
-		'PhanUndeclaredClassProperty',
+		// 'PhanUndeclaredClassProperty',
 		'PhanTypeArraySuspiciousNullable',
 		// 'PhanPluginInconsistentReturnMethod',
 		'PhanTypeExpectedObjectPropAccessButGotNull',
@@ -643,11 +643,13 @@
 		'ftp'  => PHAN_DIR . '/stubs/ftp.phan_php',
 		'gd'  => PHAN_DIR . '/stubs/gd.phan_php',
 		'geoip'  => PHAN_DIR . '/stubs/geoip.phan_php',
+		'imagick'  => PHAN_DIR . '/stubs/imagick.phan_php',
 		'imap'  => PHAN_DIR . '/stubs/imap.phan_php',
 		'intl'  => PHAN_DIR . '/stubs/intl.phan_php',
 		'ldap'  => PHAN_DIR . '/stubs/ldap.phan_php',
 		'mcrypt'  => PHAN_DIR . '/stubs/mcrypt.phan_php',
 		'memcache'  => PHAN_DIR . '/stubs/memcache.phan_php',
+		'memcached' => PHAN_DIR . '/stubs/memcached.phan_php',
 		'mysqli'  => PHAN_DIR . '/stubs/mysqli.phan_php',
 		'pdo_cubrid'  => PHAN_DIR . '/stubs/pdo_cubrid.phan_php',
 		'pdo_mysql'  => PHAN_DIR . '/stubs/pdo_mysql.phan_php',
@@ -658,6 +660,7 @@
 		'simplexml'  => PHAN_DIR . '/stubs/SimpleXML.phan_php',
 		'soap'  => PHAN_DIR . '/stubs/soap.phan_php',
 		'sockets'  => PHAN_DIR . '/stubs/sockets.phan_php',
+		'tidy'  => PHAN_DIR . '/stubs/tidy.phan_php',
 		'zip'  => PHAN_DIR . '/stubs/zip.phan_php',
 	],
 ];

dev/tools/phan/config_extended.php

@@ -397,10 +397,12 @@
 	'gd'  => PHAN_DIR . '/stubs/gd.phan_php',
 	'geoip'  => PHAN_DIR . '/stubs/geoip.phan_php',
 	'imap'  => PHAN_DIR . '/stubs/imap.phan_php',
+	'imagick'  => PHAN_DIR . '/stubs/imagick.phan_php',
 	'intl'  => PHAN_DIR . '/stubs/intl.phan_php',
 	'ldap'  => PHAN_DIR . '/stubs/ldap.phan_php',
 	'mcrypt'  => PHAN_DIR . '/stubs/mcrypt.phan_php',
 	'memcache'  => PHAN_DIR . '/stubs/memcache.phan_php',
+	'memcached' => PHAN_DIR . '/stubs/memcached.phan_php',
 	'mysqli'  => PHAN_DIR . '/stubs/mysqli.phan_php',
 	'pdo_cubrid'  => PHAN_DIR . '/stubs/pdo_cubrid.phan_php',
 	'pdo_mysql'  => PHAN_DIR . '/stubs/pdo_mysql.phan_php',
@@ -411,6 +413,7 @@
 	'simplexml'  => PHAN_DIR . '/stubs/SimpleXML.phan_php',
 	'soap'  => PHAN_DIR . '/stubs/soap.phan_php',
 	'sockets'  => PHAN_DIR . '/stubs/sockets.phan_php',
+	'tidy' => PHAN_DIR . '/stubs/tidy.phan_php',
 	'zip'  => PHAN_DIR . '/stubs/zip.phan_php',
 	],
 

dev/tools/phan/config_fixer.php

@@ -228,10 +228,12 @@
 	'gd'  => PHAN_DIR . '/stubs/gd.phan_php',
 	'geoip'  => PHAN_DIR . '/stubs/geoip.phan_php',
 	'imap'  => PHAN_DIR . '/stubs/imap.phan_php',
+	'imagick'  => PHAN_DIR . '/stubs/imagick.phan_php',
 	'intl'  => PHAN_DIR . '/stubs/intl.phan_php',
 	'ldap'  => PHAN_DIR . '/stubs/ldap.phan_php',
 	'mcrypt'  => PHAN_DIR . '/stubs/mcrypt.phan_php',
 	'memcache'  => PHAN_DIR . '/stubs/memcache.phan_php',
+	'memcached' => PHAN_DIR . '/stubs/memcached.phan_php',
 	'mysqli'  => PHAN_DIR . '/stubs/mysqli.phan_php',
 	'pdo_cubrid'  => PHAN_DIR . '/stubs/pdo_cubrid.phan_php',
 	'pdo_mysql'  => PHAN_DIR . '/stubs/pdo_mysql.phan_php',
@@ -241,6 +243,7 @@
 	'session'  => PHAN_DIR . '/stubs/session.phan_php',
 	'simplexml'  => PHAN_DIR . '/stubs/SimpleXML.phan_php',
 	'soap'  => PHAN_DIR . '/stubs/soap.phan_php',
+	'tidy' => PHAN_DIR . '/stubs/tidy.phan_php',
 	'sockets'  => PHAN_DIR . '/stubs/sockets.phan_php',
 	'zip'  => PHAN_DIR . '/stubs/zip.phan_php',
 	],