Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: upgrade minimum version of dolibarr for module builder #29015

Conversation

FHenry
Copy link
Member

@FHenry FHenry commented Mar 21, 2024

Module builder use feature than are not available in version 11. Seems reasonable to upgrade it at least to version 17 of dolibarr

@sonikf
Copy link
Contributor

sonikf commented Mar 21, 2024

Hi @FHenry
I've just noticed that code generated with module builder in v.19 breaks in v18
e.g. in actions_mymodule.class.php

require_once DOL_DOCUMENT_ROOT.'/core/class/commonhookactions.class.php';

/**
 * Class ActionsMyModule
 */
class ActionsMyModule extends CommonHookActions

@FHenry
Copy link
Member Author

FHenry commented Mar 22, 2024

Hi @FHenry I've just noticed that code generated with module builder in v.19 breaks in v18 e.g. in actions_mymodule.class.php

require_once DOL_DOCUMENT_ROOT.'/core/class/commonhookactions.class.php';

/**
 * Class ActionsMyModule
 */
class ActionsMyModule extends CommonHookActions

Yes , that a fact with the module builder, each version is compatible only with the version of dolibarr design for.
In version 19, there is a new abstract class CommonHookActions that do not exists previous version.
The version comptability with module builder is better from previous version to upper, I mean make a module with module builder in version 17, it will still works in version 19.

@eldy eldy merged commit 7940b13 into Dolibarr:develop Mar 23, 2024
5 of 6 checks passed
@FHenry FHenry deleted the dev_upgrade_min_version_from_module_builder_template branch March 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants