New allow modify stock_theorique, not only replace by hook. #26398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think virtual stock should be used for quarantine stock. This is a bad idea and breaks the inventory valuation model. This is not a good use case. |
|
@Ashley-Butcher Is only hook for external module. Made this PR after reading comments on your issue to see if possible to modify virtual stock calculation by hook. Not really related to your issue, only gave idea. Before hook replace all calculation, for me make no sense, is same as override load_virtual_stock function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Not only replace virtual stock calculation but also allow modify virtual stock by some additional stat.
For example #26384 reduce by quarantine stock.