FIX #25853 Thirdparty Massaction #25868
Open
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Sep 11, 2023
| // if (isset($this->total_localtax1)) $this->total_localtax1=trim($this->total_localtax1); | ||
| // if (isset($this->total_localtax2)) $this->total_localtax2=trim($this->total_localtax2); | ||
| if (isset($this->total_localtax1)) { | ||
| $this->total_localtax1=trim($this->total_localtax1); |
There was a problem hiding this comment.
Welcome back juanjo !
We should not use trim here, because total_localtax1 should be a float here when calling the method. And trim is designed for string. May be you want to do this ?
if (empty($this->total_localtax1)) {
$this->total_localtax1 = 0;
}
There was a problem hiding this comment.
Thank you Laurent for the welcome,
Ok, I had only uncommented the lines, now changed by empty check and make and also done for total_ttc
eldy
added
the
Discussion
# Conflicts: # htdocs/core/lib/functions.lib.php
| if (empty($this->total_localtax2)) { | ||
| $this->total_localtax2 = 0; | ||
| } | ||
| if (empty($this->total_ttc)) { |
There was a problem hiding this comment.
@eldy @simnandez
On develop you have "if (isset($this->total_ttc)) {" and maybe it not needeed for yout fix (can occur conflicts with develop branch)
|
same point as lvessiller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.