Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvement #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link
Contributor

Changed log

  • Since the php-7.0 version is inactive and let this package require php-7.1 version at least.
  • Add ^7.0||^8.0 for PHPunit versions to be compatible different PHP versions.
  • Add *.cache on .gitignore file to let cached file not under Git version control.
  • Add test DivineOmega\WordInfo\Tests; class namespace to load test classes automatically.
  • The satooshi/php-coveralls package is deprecated and using php-coveralls/php-coveralls package instead.
  • Since the expected value has been changed from remote API. And the original assertions will be failed.
    To avoid failed assertion happen, using the convertObjectValueToString method to convert object value to expected array and assert expected is same as result.
  • Using the assertTrue and assertFalse to assert expected is true or false.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.721%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 59
Relevant Lines: 61

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.721%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 59
Relevant Lines: 61

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.721%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 59
Relevant Lines: 61

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.721%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 59
Relevant Lines: 61

💛 - Coveralls

@peter279k
Copy link
Contributor Author

@DivineOmega, please look at PR at your available time. Thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants