Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mutable layout getters to layout setters #583

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Nov 22, 2023

Objective

This makes it easier to integrate with Taffy as:

  • It means you don't necessarily have to store the layout as a taffy::Layout struct
  • It allows you to run logic just after the layout is set

It also makes it clear that Taffy's algorithms do not read from the layout (and removes the one case where they did!).

Context

This change is motivated by the Xilem integration linebender/xilem#140

@nicoburns nicoburns added the usability Make the library more comfortable to use label Nov 22, 2023
@nicoburns nicoburns added this to the 0.4 milestone Nov 22, 2023
@nicoburns nicoburns merged commit 7781c70 into DioxusLabs:main Nov 22, 2023
18 checks passed
@nicoburns nicoburns deleted the set-layout branch November 22, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Make the library more comfortable to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant