Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #980 Adds Plugins to Persistent volumes in Dockerfile #986

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

Nixis198
Copy link
Contributor

No description provided.

@Difegue
Copy link
Owner

Difegue commented Jun 12, 2024

I wonder how this will work with updates -- If you install a new version of the server that updates the bundled plugins, will they overwrite the ones in an existing volume correctly?
That's the main reason I always left the plugin directory nonexposed, but I've never tested this stuff in detail..

@siliconfeces
Copy link
Contributor

What about scanning for plugins recursively in the path? In that case, one can split it up fairly easily without causing too much issues with existing installs. Leave the bundled plugins in the base Plugins directory and store uploaded plugins in Plugins/Uploaded. The latter can be exposed as a docker volume/path if you want persistent uploaded plugins.

It will also be possible to install sets of plugins through additional mounts like Plugins/MyPlugins.

@Difegue
Copy link
Owner

Difegue commented Jun 14, 2024

The issue with that is that Perl uses the folder structure to do namespace lookups, so uploaded plugins would need a new namespace.. Although thinking on it there's no reason we shouldn't be able to bodge this with symlinks in the container.

Edit: although after doing some searching I might actually be wrong on that point? It's worth a try at least

@Difegue Difegue linked an issue Jul 9, 2024 that may be closed by this pull request
@Difegue
Copy link
Owner

Difegue commented Jul 9, 2024

I've hijacked the PR to add a Sideloaded folder that Plugin uploads will now land into.
Seems like there's no issue having a bunch of differently namespaced files in that random folder, so it should now carry over between Docker installs just fine.

@Difegue Difegue merged commit 379fa72 into Difegue:dev Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uploaded plugins gone if docker container recreated
3 participants