fix: issue #1115 handling integer parsing in SETBIT in certain situation #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvyadav1111
requested changes
Oct 19, 2024
|
@apoorvyadav1111 is this PR unblocked now? |
|
Yes @JyotinderSingh , we can merge this now |
|
@kaushal-003 please rebase on the latest master |
|
Sure, will do it by tonight. |
|
@JyotinderSingh Done rebasing |
apoorvyadav1111
requested changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #1115:
Description:
ByteSliceToObjfunction to handle integer parsing more robustly. If the modified byte array can't be parsed as an integer, it now defaults to a string format(similar to how redis handles it).