Unpin versions of ipykernel, notebook, pyzmq and tornado dependencies; add FAQ #398
Conversation
willfurnass
changed the title
willfurnass
changed the title
This unpinning requires that we also set a minimum version of the ipython dependency to avoid the recurrence of an issue where interactively changing the state of ipywidgets causes duplicate Figures to be created. Also added a FAQ that recommends users update their dependencies if they encounter this issue.
willfurnass
force-pushed
the
unpin_ipykernel_notebook_pyzmq_tornado
branch
from
7ddbdef to
560adbe
Compare
willfurnass
changed the title
willfurnass
changed the title
|
Huh, CI job status info isn't being shown for this PR. Jobs are running though: https://travis-ci.org/github/DiODeProject/MuMoT/builds/667690510 |
|
CI jobs completed sucessfully; awaiting review. |
There was a problem hiding this comment.
Having checked on MyBinder via Safari, this seems not to reopen #158 , and close #397 - suggest @joefresna takes a look in other browsers, but I'm happy
There was a problem hiding this comment.
I tested it on Chrome and Safari and in both cases it works fine for me.
Latex symbols do not break the line and I don't have duplicated figures.
To be sure, I executed the following command to test the system. Let me know if I've done something wrong...
git fetch --all
git checkout unpin_ipykernel_notebook_pyzmq_tornado
conda update conda
conda create -n mumot-env-pr python=3.7
conda activate mumot-env-pr
conda install graphviz
python -m pip install /Users/joefresna/MuMoT/
jupyter notebook
|
@willfurnass unless you have a reason not to I think this is now good to merge... |
Need to do so without resurrecting #158 (duplicate Figures created upon ipywidget state changes).
The trick here is to set a minimum version of
ipython(7.10.0).Also added a FAQ that recommends users update their dependencies if they
encounter the duplicate Figure issue.