-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict ipykernel, tornado and pyzmq versions so do not get extra figs when wiggle ipywidgets #210
Conversation
…gs when wiggle ipywidgets
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 58.82% 58.79% -0.04%
==========================================
Files 6 6
Lines 8377 8377
Branches 1769 1769
==========================================
- Hits 4928 4925 -3
- Misses 2986 2988 +2
- Partials 463 464 +1
Continue to review full report at Codecov.
|
e26e85c
to
e908e16
Compare
I am ready to review this but need to check how to do so - I've been using condo envs so imagine I have to deactivate my environment, then |
That seems to work using the above method - however not sure how to include graphviz in the requirements using this installation method. |
@jarmarshall You can install MuMot using pip an in a 'bare' Python 3.6 conda environment or in a Python 3.6 virtualenv. You can install graphviz using conda or using the OS pkg manager. |
OK, so we will need to add graphviz installation to the revised installation instructions I do worry slightly about how future-proof going down this route of restricting package versions is, but we already had to do that unfortunately to to dependencies on, e.g. PyDStool |
@jarmarshall graphviz is already listed in the install instructions: https://mumot.readthedocs.io/en/latest/install.html
There is far less package version pinning in setup.py than the conda environment definition files: only explicit requirements are listed in setup.py, whereas the conda environment definitions are exhaustive lists of the specific versions of all packages that were implicit and explicitly installed in an environment at a particular moment in time. |
@joefresna does commit 83efeed mean we can close this? Have we verified that the duplicate figures issue is fixed on Windows by this? If so can @willfurnass resolve conflicts and tick off the remaining items to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on testing on Windows reported by @eliseofe this can be merged
The associated update to the docs (see checklist above) is in PR #229 |
Tested on mybinder |
Hopefully fixes Issue #158 i.e. ensure that superfluous figures aren't created when wiggling ipywidgets after installing just the MuMoT package (i.e. using just the requirements specified in
setup.py
, not using arequirements.txt
orenvironment.yml
). #100 can therefore also be closed if this works.Some explanation:
ipykernel
package is < 4.7.ipykernel
< 4.7 requires that thetornado
package is < 5 (otherwise you getRuntimeError: This event loop is already running
)tornado
< 5 requires that thepyzmq
package is < 17 (otherwise you getValueError: signal only works in main thread
)pyzmq
package is < 17 requires that thenotebook
package is <5.5 (otherwise you see the following warning at install time:notebook 5.7.0 has requirement pyzmq>=17, but you'll have pyzmq 16.0.4 which is incompatible.
)@jarmarshall @tbose1 @joefresna Please test locally on macOS and Windows in Python 3.6 virtualenvs and/or conda envs.
If this works we need to:
.
' i.e the package in the current directory)