Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure can create models from a string instead of a cell reference #200

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

willfurnass
Copy link
Collaborator

Directly addresses #156. Could also help with #157 (measuring code coverage during Notebook runs).

@willfurnass willfurnass self-assigned this Oct 10, 2018
@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #200 into master will increase coverage by 37.61%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #200       +/-   ##
===========================================
+ Coverage   21.21%   58.82%   +37.61%     
===========================================
  Files           6        6               
  Lines        8376     8377        +1     
  Branches     1768     1769        +1     
===========================================
+ Hits         1777     4928     +3151     
+ Misses       6556     2977     -3579     
- Partials       43      472      +429
Impacted Files Coverage Δ
mumot/__init__.py 66.9% <87.5%> (+58.22%) ⬆️
mumot/gen/PSParser.py 42% <0%> (+3.47%) ⬆️
mumot/process_latex/process_latex.py 23.84% <0%> (+7.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87307e5...4659d2c. Read the comment docs.

@willfurnass willfurnass merged commit 5ed8360 into DiODeProject:master Oct 17, 2018
@willfurnass willfurnass deleted the model_from_string branch October 17, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants