Skip to content

Commit

Permalink
Match the new source_url on the reference document
Browse files Browse the repository at this point in the history 
The `source_url` of the images on the reference document has changed. As
a result the `check_google_doc_export` fails.

We would normally expect these to be static, if there is another change
down the line we can consider comparing the export without the
`source_url`
  • Loading branch information
@damiendillon @dsager
damiendillon authored and dsager committed Jan 23, 2024
1 parent 6fdfb6c commit fc46924
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion spec/article_json/import/google_doc/html/parser_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"content": [
{
"type": "image",
"source_url": "https://lh7-us.googleusercontent.com/H28MfU2_fPpHJ2UP16JLs7nWHvRAN0fEguVpp9ZOmtLNvxp4oNgKNn_fycYVcb1ScgdQ-UPLjBdoKdl5hsmsPxhfOZ3RiheScNhIw68UAHYfmuzObdnfxidlph1o0rbxKzE1n6s3_wivLsU",
"source_url": "https://lh7-us.googleusercontent.com/7bgjcEQ6DWAfTzeb-RY5ExlTBWkHdqQf9PSK7ck3IxzI2sVDrm_hfI6jT-c04tenqOWWtWMxMQyWX0fEZeN3aVbBC_YsCCKm0vmddGeRgIETJ5yJbQoGCzh4dwCo0bPGfh5rTljMk8PEvwQ",
"float": "left",
"caption": [
{
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/google_doc_image_with_link.html
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<html><head><meta content="text/html; charset=UTF-8" http-equiv="content-type"><style type="text/css">ol{margin:0;padding:0}table td,table th{padding:0}.c0{color:#000000;font-weight:400;text-decoration:none;vertical-align:baseline;font-size:11pt;font-family:"Arial";font-style:normal}.c1{padding-top:0pt;padding-bottom:0pt;line-height:1.15;orphans:2;widows:2;text-align:left}.c2{background-color:#ffffff;max-width:468pt;padding:72pt 72pt 72pt 72pt}.title{padding-top:0pt;color:#000000;font-size:26pt;padding-bottom:3pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}.subtitle{padding-top:0pt;color:#666666;font-size:15pt;padding-bottom:16pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}li{color:#000000;font-size:11pt;font-family:"Arial"}p{margin:0;color:#000000;font-size:11pt;font-family:"Arial"}h1{padding-top:20pt;color:#000000;font-size:20pt;padding-bottom:6pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h2{padding-top:18pt;color:#000000;font-size:16pt;padding-bottom:6pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h3{padding-top:16pt;color:#434343;font-size:14pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h4{padding-top:14pt;color:#666666;font-size:12pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h5{padding-top:12pt;color:#666666;font-size:11pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h6{padding-top:12pt;color:#666666;font-size:11pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;font-style:italic;orphans:2;widows:2;text-align:left}</style></head><body class="c2"><div><p class="c2"><span style="overflow: hidden; display: inline-block; margin: 0.00px 0.00px; border: 0.00px solid #000000; transform: rotate(0.00rad) translateZ(0px); -webkit-transform: rotate(0.00rad) translateZ(0px); width: 294.72px; height: 193.00px;"><img alt="" src="https://lh7-us.googleusercontent.com/H28MfU2_fPpHJ2UP16JLs7nWHvRAN0fEguVpp9ZOmtLNvxp4oNgKNn_fycYVcb1ScgdQ-UPLjBdoKdl5hsmsPxhfOZ3RiheScNhIw68UAHYfmuzObdnfxidlph1o0rbxKzE1n6s3_wivLsU" style="width: 294.72px; height: 193.00px; margin-left: 0.00px; margin-top: 0.00px; transform: rotate(0.00rad) translateZ(0px); -webkit-transform: rotate(0.00rad) translateZ(0px);" title=""></span></p><p class="c2"><span>[image-link-to: http://www.devex.com] This is the caption of the image</span></p></div></body></html>
<html><head><meta content="text/html; charset=UTF-8" http-equiv="content-type"><style type="text/css">ol{margin:0;padding:0}table td,table th{padding:0}.c0{color:#000000;font-weight:400;text-decoration:none;vertical-align:baseline;font-size:11pt;font-family:"Arial";font-style:normal}.c1{padding-top:0pt;padding-bottom:0pt;line-height:1.15;orphans:2;widows:2;text-align:left}.c2{background-color:#ffffff;max-width:468pt;padding:72pt 72pt 72pt 72pt}.title{padding-top:0pt;color:#000000;font-size:26pt;padding-bottom:3pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}.subtitle{padding-top:0pt;color:#666666;font-size:15pt;padding-bottom:16pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}li{color:#000000;font-size:11pt;font-family:"Arial"}p{margin:0;color:#000000;font-size:11pt;font-family:"Arial"}h1{padding-top:20pt;color:#000000;font-size:20pt;padding-bottom:6pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h2{padding-top:18pt;color:#000000;font-size:16pt;padding-bottom:6pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h3{padding-top:16pt;color:#434343;font-size:14pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h4{padding-top:14pt;color:#666666;font-size:12pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h5{padding-top:12pt;color:#666666;font-size:11pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;orphans:2;widows:2;text-align:left}h6{padding-top:12pt;color:#666666;font-size:11pt;padding-bottom:4pt;font-family:"Arial";line-height:1.15;page-break-after:avoid;font-style:italic;orphans:2;widows:2;text-align:left}</style></head><body class="c2"><div><p class="c2"><span style="overflow: hidden; display: inline-block; margin: 0.00px 0.00px; border: 0.00px solid #000000; transform: rotate(0.00rad) translateZ(0px); -webkit-transform: rotate(0.00rad) translateZ(0px); width: 294.72px; height: 193.00px;"><img alt="" src="https://lh7-us.googleusercontent.com/7bgjcEQ6DWAfTzeb-RY5ExlTBWkHdqQf9PSK7ck3IxzI2sVDrm_hfI6jT-c04tenqOWWtWMxMQyWX0fEZeN3aVbBC_YsCCKm0vmddGeRgIETJ5yJbQoGCzh4dwCo0bPGfh5rTljMk8PEvwQ" style="width: 294.72px; height: 193.00px; margin-left: 0.00px; margin-top: 0.00px; transform: rotate(0.00rad) translateZ(0px); -webkit-transform: rotate(0.00rad) translateZ(0px);" title=""></span></p><p class="c2"><span>[image-link-to: http://www.devex.com] This is the caption of the image</span></p></div></body></html>
2 changes: 1 addition & 1 deletion spec/fixtures/reference_document.html
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion spec/fixtures/reference_document_exported.amp.html
View file

Large diffs are not rendered by default.

Loading

0 comments on commit fc46924

Please sign in to comment.