fix(d-form-textarea): add the 'value' prop #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a 'value' prop to the FormTextarea didn't do anything for two reasons: * the 'value' prop wasn't declared, so it was always undefined * the 'localValue' prop wasn't passed to the underlying textarea component, so the textarea wasn't controlled (it did not show the current value). Using a v-model on the textarea simplifies the code a bit by sending and updating localValue at the same time.
requestedusernotfound
added a commit
to requestedusernotfound/shards-vue
that referenced
this pull request
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a
valueprop to theFormTextareadidn't do anything for two reasons:the
valueprop wasn't declared, so it was always undefinedthe
localValueprop wasn't passed to the underlying textarea component, so the textarea wasn't controlled (it did not show the current value).Using a
v-modelon the textarea simplifies the code a bit by sending and updatinglocalValueat the same time.PS - I read the contributing guidelines after making a fix for this issue, that's why I didn't take time to discuss about it first. Of course, we can still discuss this, and feel free to discard the PR completely.