Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "Enable SVG Badge support (unauthenticated)" by renaming #1019

Conversation

SaberStrat
Copy link

@SaberStrat SaberStrat commented Sep 29, 2024

Description

Originally planned to be a removal of the switch (#985) (and the feature of removing a globally configurable unauthenticated access to the badges API in Dependency-Track API), after some discussions it was decided to make it a deprecated feature with for the next minor version release of DT, with a planned removal of the feature in the minor release after that.

As this deprecation-change is planned to be removed sooner than later, I'd like to keep the template name as it is, despite it not describing its function in Dependency-Track accurately for the time of the deprecation, to keep the changeload for this deprecation low:

  • previously, for enabling support of badges in DT, enable_svg_badge
  • this PR, enabling unauthenticated access ot badges in DT, otherwise still supporting the feature but only with authenticated and authorized access, so could've been enable_unauthenticated_svg_badge.

And the ConfigProperty's name in DT modified by this would also remain as it was too for the remainder of the deprecation until removal.

Downstream change of DependencyTrack/dependency-track#4059

Addressed Issue

Closes #1009

Additional Details

Checklist

@SaberStrat SaberStrat marked this pull request as ready for review September 29, 2024 16:56
@nscuro nscuro added the enhancement New feature or request label Sep 29, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 29, 2024
@nscuro nscuro merged commit 9b924de into DependencyTrack:master Sep 29, 2024
10 checks passed
@SaberStrat SaberStrat deleted the feature/1009-rename-badge-enabling-switch-in-settings branch September 30, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants