Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: embedded code samples rework #1328

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

fundthmcalculus
Copy link
Contributor

@fundthmcalculus fundthmcalculus commented Mar 9, 2023

  • Injected code sample tabs are now created by a macro for consistency and simplicity
  • There is an additional output on protoc-gen-sdk which creates all endpoints in the docs/reference/services-generated folder so you can copy-paste the new endpoints over. feat: Add Docs as a new target trinsic-id/protoc-gen-sdk#55
  • Working on the Dart samples of the new layout
  • Required code files are added in the necessary locations, if you need/want to move them to a subfolder, we can, just talk to me so I can update the macro.

@fundthmcalculus fundthmcalculus requested review from geel9 and Hmac512 March 9, 2023 17:09
@tmarkovski
Copy link
Contributor

Bump. Is this work still pending or can we close this? @fundthmcalculus

@fundthmcalculus
Copy link
Contributor Author

This was work that needed to be done, but was put on hold per @janpieterz . Happy to have a further discussion about the need for it's completion, but there's still work to do.

@janpieterz
Copy link
Contributor

I think we can cancel the work of "all languages". But this pull request might contain some changes that are useful regardless/outside of that. Are there any?

@fundthmcalculus
Copy link
Contributor Author

I think we can cancel the work of "all languages". But this pull request might contain some changes that are useful regardless/outside of that. Are there any?

There is, let me go though it and extract out the useful bits. The goal of this was to automate a lot of the sample generation so it's clearer where to put things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants