Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give users the ability to split incorrectly merged candidates #2326

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented May 26, 2024

Ref #646

This is an MVP to offer users the option to split candidates that have been incorrectly merged. While this MVP does not currently use version data from past merges to present options for splitting, there is code here to do that. Instead, this offers users the attributes of a given person to keep, move or do both for a new person.

There are still several design questions in comments, absolutely no tests and I appreciate the templates are still crude. But hopefully a decent place to start!

To test, navigate to a person view, even better if it is a person with election results entered as that is the context for this feature request. Find the button in the first screenshot on the right hand column.

At the moment, I've just offered users name and gender to work with; there are outstanding questions in the code about how best to present users with available fields and what to do about required fields.

  • Add a button on the person view for users to choose to split
Screenshot 2024-05-30 at 1 07 54 PM
  • Present the user with a form template for selecting various properties to add to each person (1st, 2nd or both)
Screenshot 2024-05-30 at 1 09 50 PM
  • Submit the previous form to the pre-split review page
Screenshot 2024-05-30 at 1 10 20 PM
  • Post split confirmation page
Screenshot 2024-05-30 at 1 07 20 PM

@VirginiaDooley VirginiaDooley force-pushed the hotfix/split-candidates branch 4 times, most recently from 7932e82 to d47174f Compare May 28, 2024 15:15
@VirginiaDooley VirginiaDooley changed the title WIP Add the front end option to split WIP Add the front end option to split incorrectly merged candidates May 29, 2024
@VirginiaDooley VirginiaDooley changed the title WIP Add the front end option to split incorrectly merged candidates WIP Give users the ability to split incorrectly merged candidates May 29, 2024
@VirginiaDooley VirginiaDooley force-pushed the hotfix/split-candidates branch 4 times, most recently from e2d51eb to 91cead4 Compare May 30, 2024 12:24
@VirginiaDooley VirginiaDooley marked this pull request as ready for review May 30, 2024 12:30
@VirginiaDooley VirginiaDooley changed the title WIP Give users the ability to split incorrectly merged candidates Give users the ability to split incorrectly merged candidates May 30, 2024
@VirginiaDooley VirginiaDooley requested a review from pmk01 May 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant