Do not compare types, use isinstance()

.gitignore

@@ -26,7 +26,7 @@ node_modules/
 /test-env
 /ynr/apps/sopn_parsing/tests/data/sopn_baseline.json
 /ynr/apps/sopn_parsing/tests/data/sopn_baseline_copy.json
-
+/src
 # PyCharm
 .idea/
 

ynr/apps/api/templatetags/api_docs.py

@@ -13,7 +13,7 @@ def link_to_definition(value, version_and_label="next"):
     ref_id = None
     if type(value) in (SchemaRef, dict):
         ref_id = value["$ref"].split("/")[-1]
-    if type(value) == tuple:
+    if isinstance(value, tuple):
         ref_id = value[1]
     if isinstance(value, str):
         ref_id = value

ynr/apps/parties/api/next/api_views.py

@@ -74,7 +74,7 @@ def get(self, request, *args, **kwargs):
         for party in qs:
             item = {}
 
-            if type(party[1]) == list:
+            if isinstance(party[1], list):
                 # This is a party with descriptions
                 item["text"] = party[0]
                 item["children"] = []

ynr/apps/people/forms/fields.py

@@ -117,7 +117,7 @@ class BlankApproximateDateFormField(ApproximateDateFormField):
     """
 
     def clean(self, value):
-        if type(value) == str:
+        if isinstance(value, str):
             value = value.replace("-00", "-01")
         value = super().clean(value)
         if not value:

ynr/apps/resultsbot/importers/modgov.py

@@ -17,7 +17,7 @@ class ModGovCandidate(BaseCandidate):
     def __init__(self, candidate_xml, division):
         self.division = division
         self.xml = candidate_xml
-        if type(candidate_xml) == str:
+        if isinstance(candidate_xml, str):
             self.soup = BeautifulSoup(self.xml, "xml")
         else:
             self.soup = candidate_xml

ynr/apps/utils/widgets.py

@@ -16,7 +16,7 @@ class SelectWithAttrs(Select):
     def create_option(
         self, name, value, label, selected, index, subindex=None, attrs=None
     ):
-        if type(label) == dict:
+        if isinstance(label, dict):
             label = dict(label)
             label_text = label.pop("label")
         else: