Merge pull request #2474 from DemocracyClub/completeness-performance

Simplify query to candidate completeness view
DemocracyClub · Nov 13, 2024 · c13a666 · c13a666
2 parents 67149e9 + d12a3b5
commit c13a666
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ynr/apps/cached_counts/templates/candidate_completeness.html b/ynr/apps/cached_counts/templates/candidate_completeness.html
@@ -78,9 +78,9 @@ <h2>Stats</h2>
             <tbody>
             {% for membership in qs %}
                 <tr>
-                    <td><a href="{{ membership.person.get_absolute_url }}">{{ membership.person.name }}</a></td>
+                    <td><a href="{% url "person-view" membership.person_id %}">{{ membership.person_name }}</a></td>
                     <td>
-                        <a href="{{ membership.ballot_paper.get_absolute_url }}">{{ membership.ballot_paper.ballot_paper_id }}</a>
+                        <a href="{% url "election_view" membership.ballot_paper_id %}">{{ membership.ballot_paper_id }}</a>
                     </td>
                     <td>{{ membership.party_name }}</td>
                     {% for identifier_field in identifier_fields %}

diff --git a/ynr/apps/cached_counts/views.py b/ynr/apps/cached_counts/views.py
@@ -181,7 +181,7 @@ def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         qs = MaterializedMemberships.objects.filter(
             ballot_paper__election__slug=self.election
-        ).select_related("person", "ballot_paper")
+        )
 
         identifier_fields = sorted(pi.name for pi in PersonIdentifierFields)
         annotations = {}