Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue devtools. #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankperez87
Copy link

This adds Vue Devtools support.

One thing to note is that you will get a warning stating:
Manifest version 2 is deprecated, and support will be removed in 2023.

This is already being addressed within the vuejs devtools repo here
vuejs/devtools#1917

@frankperez87 frankperez87 mentioned this pull request Nov 24, 2022
@Deluze
Copy link
Owner

Deluze commented Nov 24, 2022

Thanks for this PR!

I would like to merge this, but I'm running against some errors locally:

[electron] [38620:1124/235749.957:ERROR:CONSOLE(160)] "Electron sandbox_bundle.js script failed to run", source: node:electron/js2c/sandbox_bundle (160)
[38620:1124/235749.957:ERROR:CONSOLE(160)] "TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))", source: node:electron/js2c/sandbox_bundle (160)

I'm not sure what causes this yet, but doing a quick google search it seems more people have ran into this issue. This error pops up on start, and more of them get logged after opening the Vue devtools.

Another issue is that the Content Security Policy header is blocking a request to a script that Vue Devtool is trying to load and execute... thinking of omitting the header and let the developers decide what they want to do with it.

[electron] [51244:1124/235652.437:ERROR:CONSOLE(0)] "Refused to load the script 'https://cdn.headwayapp.co/widget.js' because it violates the following Content Security Policy directive: "script-src 'self'". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

@Deluze
Copy link
Owner

Deluze commented Nov 24, 2022

I'm thinking that the remote vue devtools package might be a better (temporary) solution until these errors are fixed. Only downside is that the devtools is a separate process on the machine, at least the developer can then decide if they want to launch the devtools or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants