feat: 659 convert damage classes into dataclasses; add a reader for damage curves #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This was
unlinked from
issues
Dec 12, 2024
ArdtK
changed the title
ArdtK
changed the title
…s-without-input-files
…ut-files' of https://github.com/Deltares/ra2ce into feat/654-experiment-with-damages-and-losses-without-input-files
Carsopre
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Some remarks need to be addressed prior to merge of this issue. Please have special attention to the comments made on ra2ce/analysis/damages/damage_functions/damage_function_road_type_lane.py
In addition, please ensure either the issue linked to this PR or its parent issue contain a description on why these changes are required.
ra2ce/analysis/damages/damage_functions/damage_fraction_uniform.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_functions/damage_fraction_uniform.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_functions/damage_function_road_type_lane.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_functions/damage_function_road_type_lane.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_calculation/damage_network_base.py
Outdated
Show resolved
Hide resolved
tests/analysis/damages/damage_functions/test_manual_damage_functions_reader.py
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_functions/damage_function_road_type_lane.py
Outdated
Show resolved
Hide resolved
ra2ce/analysis/damages/damage_functions/manual_damage_functions_reader.py
Outdated
Show resolved
Hide resolved
Carsopre
approved these changes
Dec 13, 2024
ra2ce/analysis/damages/damage_calculation/damage_network_return_periods.py
Outdated
Show resolved
Hide resolved
ArdtK
deleted the
feat/654-experiment-with-damages-and-losses-without-input-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Solves #659
Code of conduct
What has been done?
analysis\damages\damagetoanalysis\damages\damage_functions. Not having damages functions will fail not the initialization.ManualDamageFunctionsinto a dataclass and a reader.DamageFractionUniformandMaxDamage(renamed fromMaxDamageByRoadTypeByLane) into dataclasses.Damagesto read the damage functions in the init.Checklist
blackandisortdefinitions.master.Additional Notes (optional)
Add any additional notes or information that may be helpful.